Skip to content

Code changes in Bls_Cpi_category to fetch montly file of year 2025 #1887

Open
niveditasing wants to merge 4 commits intodatacommonsorg:masterfrom
niveditasing:Code_changes_to_fectch_montly_data
Open

Code changes in Bls_Cpi_category to fetch montly file of year 2025 #1887
niveditasing wants to merge 4 commits intodatacommonsorg:masterfrom
niveditasing:Code_changes_to_fectch_montly_data

Conversation

@niveditasing
Copy link
Contributor

@niveditasing niveditasing commented Feb 11, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 11, 2026

Summary of Changes

Hello @niveditasing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data ingestion process for BLS CPI category data by introducing a more resilient year-rollover mechanism. It dynamically determines the "effective" current year for data retrieval based on the availability of January files, ensuring continuous data collection even when the new year's data is not yet fully published. Additionally, it refines the monthly file download strategy and adds a robust URL existence check.

Highlights

  • Year Rollover Handling: Implemented logic to dynamically adjust the 'current year' for data fetching if the January file for the actual current year is not yet published by BLS, preventing data loss during year transitions.
  • URL Existence Check: Added a new utility function url_exists to verify the availability of a URL without downloading the full content, specifically designed to work around BLS's blocking of HEAD requests.
  • Refined Monthly File Downloads: Updated the download strategy for current/effective year CPI-U and CPI-W files to attempt downloading all available monthly files up to the effective_max_month, rather than just January and the single latest.
Changelog
  • statvar_imports/us_bls/cpi_category/cpi_category_download.py
    • Added a new utility function url_exists to check URL availability.
    • Implemented logic to determine an effective_current_year and effective_max_month based on the presence of January files for the actual current year.
    • Modified loops and download logic to use effective_current_year and effective_max_month for fetching c-cpi-u, historical January, and current year cpi-u/cpi-w files.
    • Updated logging messages to reflect the use of the effective year.
    • Adjusted the latest_year and years_to_download_zip parameters to align with the effective_current_year logic.
Activity
  • No activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 11, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the download script for BLS CPI data to handle the year-end rollover more gracefully by introducing an effective_current_year. The changes also simplify the download logic for the current year's files. My review found a couple of issues with the new logic. There's a bug in how the effective month is calculated, for which I've provided a fix. Additionally, there's a redundant block of code that attempts to download files that were already downloaded, which should be removed to improve efficiency and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balit-raibot balit-raibot Awaiting requested review from balit-raibot

@saanikaaa saanikaaa Awaiting requested review from saanikaaa

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@niveditasing